Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(ci): Build more jobs in parallel #1980

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

geraldcombs
Copy link
Contributor

Pass --parallel to cmake --build. This requires CMake 3.12, but that shouldn't be a problem on the affected runners.

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Pass `--parallel` to `cmake --build`. This requires CMake 3.12, but that
shouldn't be a problem on the affected runners.

Signed-off-by: Gerald Combs <[email protected]>
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Jul 31, 2024

LGTM label has been added.

Git tree hash: af172c0138faa92515c5287bcfe55f00a3ff38ae

@FedeDP
Copy link
Contributor

FedeDP commented Jul 31, 2024

/milestone 0.18.0

@poiana poiana added this to the 0.18.0 milestone Jul 31, 2024
Copy link

Perf diff from master - unit tests

     5.36%     +0.88%  [.] next
     9.16%     +0.82%  [.] sinsp_parser::reset
     8.14%     +0.74%  [.] sinsp::next
     1.10%     -0.69%  [.] sinsp_evt::get_direction
     1.32%     -0.69%  [.] scap_next
     1.68%     -0.68%  [.] sinsp_evt::get_ts
     1.77%     -0.51%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char const*>
     4.85%     -0.48%  [.] sinsp_parser::process_event
     0.23%     +0.47%  [.] sinsp_container_manager::resolve_container
     1.27%     -0.47%  [.] sinsp_parser::event_cleanup

Perf diff from master - scap file

     3.27%     +5.68%  [.] sinsp_filter_check::tostring
    13.79%     -4.63%  [.] sinsp_filter_check::extract_nocache
    10.39%     -4.26%  [.] next
    10.43%     +3.17%  [.] sinsp_filter_check_thread::extract_single
     3.47%     +2.55%  [.] sinsp_filter_check::extract
     3.49%     +2.55%  [.] sinsp_parser::reset
     3.49%     +2.51%  [.] main
     3.46%     +2.37%  [.] libsinsp::runc::match_container_id
     6.95%     -2.35%  [.] sinsp_filter_check::get_transformed_field_info
     6.96%     -2.34%  [.] sinsp_filter_check::rawval_to_string

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: -30B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.98%. Comparing base (64fe187) to head (28ebe8b).

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #1980    +/-   ##
========================================
  Coverage   50.98%   50.98%            
========================================
  Files         310      310            
  Lines       39612    39612            
  Branches    17333    17486   +153     
========================================
  Hits        20197    20197            
+ Misses      14340    14339     -1     
- Partials     5075     5076     +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Jul 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, geraldcombs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 3ce0a2d into falcosecurity:master Jul 31, 2024
45 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants