Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): bump zig version. #2218

Merged
merged 1 commit into from
Jan 2, 2025
Merged

chore(ci): bump zig version. #2218

merged 1 commit into from
Jan 2, 2025

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Jan 2, 2025

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area CI

Does this PR require a change in the driver versions?

What this PR does / why we need it:

Should fix zig related CIs (and Falco CI).

GitHub will remove any cache entries that have not been accessed in over 7 days.

Of course 7 days limit during the winter holidays is always hit :D

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Federico Di Pierro <[email protected]>
@FedeDP
Copy link
Contributor Author

FedeDP commented Jan 2, 2025

/milestone 0.20.0

@poiana poiana added this to the 0.20.0 milestone Jan 2, 2025
Copy link

github-actions bot commented Jan 2, 2025

Perf diff from master - unit tests

    12.52%     -0.57%  [.] sinsp::next
     2.57%     -0.56%  [.] is_conversion_needed
     9.79%     +0.53%  [.] sinsp_parser::reset
     3.74%     +0.34%  [.] gzfile_read
     1.26%     +0.31%  [.] sinsp_evt_filter::sinsp_evt_filter
     2.53%     +0.29%  [.] sinsp_thread_manager::get_thread_ref
     1.31%     -0.24%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char const*>
     1.27%     -0.21%  [.] sinsp_parser::event_cleanup
     1.05%     +0.16%  [.] std::_Hashtable<unsigned long, std::pair<unsigned long const, std::shared_ptr<ppm_evt_hdr> >, std::allocator<std::pair<unsigned long const, std::shared_ptr<ppm_evt_hdr> > >, std::__detail::_Select1st, std::equal_to<unsigned long>, std::hash<unsigned long>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::_M_find_before_node
     0.31%     -0.16%  [.] sinsp_threadinfo::~sinsp_threadinfo

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            +0.0095         +0.0095           148           149           148           149
BM_sinsp_split_median                                          +0.0119         +0.0119           148           150           148           150
BM_sinsp_split_stddev                                          +0.1011         +0.1009             2             2             2             2
BM_sinsp_split_cv                                              +0.0907         +0.0906             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  +0.0049         +0.0049            56            57            56            57
BM_sinsp_concatenate_paths_relative_path_median                +0.0044         +0.0044            56            57            56            57
BM_sinsp_concatenate_paths_relative_path_stddev                -0.4105         -0.4101             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_cv                    -0.4134         -0.4130             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     +0.0169         +0.0169            25            25            25            25
BM_sinsp_concatenate_paths_empty_path_median                   +0.0154         +0.0154            25            25            25            25
BM_sinsp_concatenate_paths_empty_path_stddev                   +0.6282         +0.6284             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       +0.6012         +0.6014             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  -0.0059         -0.0059            56            56            56            56
BM_sinsp_concatenate_paths_absolute_path_median                -0.0090         -0.0090            56            56            56            56
BM_sinsp_concatenate_paths_absolute_path_stddev                -0.3931         -0.3930             1             1             1             1
BM_sinsp_concatenate_paths_absolute_path_cv                    -0.3895         -0.3894             0             0             0             0
BM_sinsp_split_container_image_mean                            +0.0124         +0.0124           383           387           383           387
BM_sinsp_split_container_image_median                          +0.0122         +0.0121           382           387           382           387
BM_sinsp_split_container_image_stddev                          +0.4561         +0.4564             2             3             2             3
BM_sinsp_split_container_image_cv                              +0.4383         +0.4386             0             0             0             0

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.44%. Comparing base (9e08d7e) to head (a5501f9).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2218   +/-   ##
=======================================
  Coverage   75.44%   75.44%           
=======================================
  Files         265      265           
  Lines       34057    34057           
  Branches     5801     5801           
=======================================
  Hits        25695    25695           
  Misses       8362     8362           
Flag Coverage Δ
libsinsp 75.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Jan 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 16ece2c into master Jan 2, 2025
49 checks passed
@poiana poiana deleted the chore/bump_zig branch January 2, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants