-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup: avoid including libscap/strl.h in connect_x #2225
Conversation
Signed-off-by: Andrea Terzolo <[email protected]>
Perf diff from master - unit tests
Heap diff from master - unit tests
Heap diff from master - scap file
Benchmarks diff from master
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2225 +/- ##
=======================================
Coverage 75.44% 75.44%
=======================================
Files 265 265
Lines 34057 34057
Branches 5801 5801
=======================================
Hits 25695 25695
Misses 8362 8362
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: 4491799048f435886f3c27248f4d25fade5db03a
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
/kind failing-test
Any specific area of the project related to this PR?
/area tests
Does this PR require a change in the driver versions?
No
What this PR does / why we need it:
This PR should fix the powerpc CI
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: