Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: avoid including libscap/strl.h in connect_x #2225

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Conversation

Andreagit97
Copy link
Member

What type of PR is this?

/kind cleanup

/kind failing-test

Any specific area of the project related to this PR?

/area tests

Does this PR require a change in the driver versions?

No

What this PR does / why we need it:

This PR should fix the powerpc CI

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Copy link

github-actions bot commented Jan 7, 2025

Perf diff from master - unit tests

    11.81%     -1.02%  [.] sinsp::next
     3.29%     +0.52%  [.] sinsp_thread_manager::find_thread
     3.61%     +0.51%  [.] gzfile_read
     3.25%     +0.49%  [.] sinsp_evt::load_params
     1.32%     -0.37%  [.] std::_Hashtable<unsigned long, std::pair<unsigned long const, std::shared_ptr<ppm_evt_hdr> >, std::allocator<std::pair<unsigned long const, std::shared_ptr<ppm_evt_hdr> > >, std::__detail::_Select1st, std::equal_to<unsigned long>, std::hash<unsigned long>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::_M_find_before_node
     1.84%     +0.34%  [.] next
    10.71%     -0.27%  [.] sinsp_parser::reset
     1.91%     -0.25%  [.] scap_event_decode_params
     1.45%     +0.24%  [.] sinsp_evt_filter::sinsp_evt_filter
     2.39%     -0.23%  [.] is_conversion_needed

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            -0.0079         -0.0080           147           146           147           146
BM_sinsp_split_median                                          -0.0104         -0.0104           146           145           146           145
BM_sinsp_split_stddev                                          +0.3677         +0.3695             1             2             1             2
BM_sinsp_split_cv                                              +0.3786         +0.3805             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  +0.0038         +0.0038            61            62            61            62
BM_sinsp_concatenate_paths_relative_path_median                +0.0037         +0.0037            61            62            61            62
BM_sinsp_concatenate_paths_relative_path_stddev                +0.0719         +0.0711             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_cv                    +0.0678         +0.0671             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0144         -0.0144            24            23            24            23
BM_sinsp_concatenate_paths_empty_path_median                   -0.0158         -0.0158            24            23            24            23
BM_sinsp_concatenate_paths_empty_path_stddev                   +1.1455         +1.1483             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       +1.1768         +1.1796             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  -0.0397         -0.0398            66            64            66            64
BM_sinsp_concatenate_paths_absolute_path_median                -0.0538         -0.0538            67            63            67            63
BM_sinsp_concatenate_paths_absolute_path_stddev                -0.3986         -0.3989             1             1             1             1
BM_sinsp_concatenate_paths_absolute_path_cv                    -0.3737         -0.3740             0             0             0             0
BM_sinsp_split_container_image_mean                            +0.0207         +0.0206           386           394           386           394
BM_sinsp_split_container_image_median                          +0.0185         +0.0184           387           394           387           394
BM_sinsp_split_container_image_stddev                          -0.1952         -0.1948             2             1             2             1
BM_sinsp_split_container_image_cv                              -0.2115         -0.2111             0             0             0             0

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.44%. Comparing base (258b4b4) to head (190869d).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2225   +/-   ##
=======================================
  Coverage   75.44%   75.44%           
=======================================
  Files         265      265           
  Lines       34057    34057           
  Branches     5801     5801           
=======================================
  Hits        25695    25695           
  Misses       8362     8362           
Flag Coverage Δ
libsinsp 75.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Jan 7, 2025

LGTM label has been added.

Git tree hash: 4491799048f435886f3c27248f4d25fade5db03a

@poiana
Copy link
Contributor

poiana commented Jan 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit e111e43 into master Jan 7, 2025
48 of 49 checks passed
@poiana poiana deleted the fix_powerpc_ci branch January 7, 2025 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants