Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: release 0.20.x #2240

Merged
merged 7 commits into from
Jan 17, 2025
Merged

sync: release 0.20.x #2240

merged 7 commits into from
Jan 17, 2025

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Jan 17, 2025

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

Does this PR require a change in the driver versions?

What this PR does / why we need it:

Cherry picks:

from master.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

therealbobo and others added 7 commits January 17, 2025 10:18
The spaces after the operator tokens were intended to indicate operators that mandate a whitespace character to be followed.

Co-authored-by: Jason Dellaluce <[email protected]>
Signed-off-by: Leonardo Grasso <[email protected]>
@poiana
Copy link
Contributor

poiana commented Jan 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana requested review from gnosek and hbrueckner January 17, 2025 09:21
@FedeDP
Copy link
Contributor Author

FedeDP commented Jan 17, 2025

/milestone 0.20.0

@poiana poiana added this to the 0.20.0 milestone Jan 17, 2025
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 61.53846% with 10 lines in your changes missing coverage. Please review.

Project coverage is 75.11%. Comparing base (5891ebd) to head (a67053f).
Report is 7 commits behind head on release/0.20.x.

Files with missing lines Patch % Lines
userspace/libsinsp/container_engine/containerd.cpp 30.00% 7 Missing ⚠️
userspace/libsinsp/runc.cpp 66.66% 3 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           release/0.20.x    #2240      +/-   ##
==================================================
+ Coverage           75.09%   75.11%   +0.02%     
==================================================
  Files                 276      276              
  Lines               34391    34394       +3     
  Branches             5927     5922       -5     
==================================================
+ Hits                25826    25836      +10     
+ Misses               8565     8558       -7     
Flag Coverage Δ
libsinsp 75.11% <61.53%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Perf diff from master - unit tests

     1.39%     -0.50%  [.] std::_Hashtable<unsigned long, std::pair<unsigned long const, std::shared_ptr<ppm_evt_hdr> >, std::allocator<std::pair<unsigned long const, std::shared_ptr<ppm_evt_hdr> > >, std::__detail::_Select1st, std::equal_to<unsigned long>, std::hash<unsigned long>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::_M_find_before_node
     2.09%     +0.45%  [.] is_conversion_needed
     5.72%     +0.37%  [.] next_event_from_file
     0.84%     +0.30%  [.] libsinsp::events::is_unknown_event
     1.38%     -0.25%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char const*>
     0.86%     -0.23%  [.] std::vector<sinsp_evt_param, std::allocator<sinsp_evt_param> >::emplace_back<sinsp_evt*, unsigned int&, char const*, unsigned long&>
     1.13%     +0.22%  [.] sinsp_parser::event_cleanup
     0.48%     -0.21%  [.] sinsp_threadinfo::~sinsp_threadinfo
     0.14%     +0.18%  [.] std::_Hashtable<conversion_key, std::pair<conversion_key const, conversion_info>, std::allocator<std::pair<conversion_key const, conversion_info> >, std::__detail::_Select1st, std::equal_to<conversion_key>, std::hash<conversion_key>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<true, false, true> >::find
    11.03%     +0.17%  [.] sinsp::next

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            -0.0226         -0.0225           153           149           153           149
BM_sinsp_split_median                                          -0.0216         -0.0215           152           149           152           149
BM_sinsp_split_stddev                                          +0.8290         +0.8270             1             1             1             1
BM_sinsp_split_cv                                              +0.8713         +0.8691             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  -0.0797         -0.0796            61            56            61            56
BM_sinsp_concatenate_paths_relative_path_median                -0.0786         -0.0786            61            56            61            56
BM_sinsp_concatenate_paths_relative_path_stddev                +0.5645         +0.5643             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_cv                    +0.7000         +0.6996             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0391         -0.0390            25            24            25            24
BM_sinsp_concatenate_paths_empty_path_median                   -0.0434         -0.0433            25            24            25            24
BM_sinsp_concatenate_paths_empty_path_stddev                   +1.8452         +1.8453             0             1             0             1
BM_sinsp_concatenate_paths_empty_path_cv                       +1.9609         +1.9607             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  -0.0875         -0.0874            63            57            63            57
BM_sinsp_concatenate_paths_absolute_path_median                -0.0813         -0.0812            62            57            62            57
BM_sinsp_concatenate_paths_absolute_path_stddev                -0.7279         -0.7277             1             0             1             0
BM_sinsp_concatenate_paths_absolute_path_cv                    -0.7018         -0.7016             0             0             0             0
BM_sinsp_split_container_image_mean                            -0.0144         -0.0143           404           398           403           398
BM_sinsp_split_container_image_median                          -0.0187         -0.0185           404           397           404           397
BM_sinsp_split_container_image_stddev                          +0.5141         +0.5136             2             4             2             4
BM_sinsp_split_container_image_cv                              +0.5362         +0.5355             0             0             0             0

@poiana poiana merged commit 5a57091 into release/0.20.x Jan 17, 2025
48 of 49 checks passed
@poiana poiana deleted the sync/release0.20.x branch January 17, 2025 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants