Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: chore(ci): port e2e tests CI to arm64 too. #2263

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Jan 31, 2025

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area CI

Does this PR require a change in the driver versions?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@poiana
Copy link
Contributor

poiana commented Jan 31, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.29%. Comparing base (3476089) to head (fbb168b).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2263      +/-   ##
==========================================
- Coverage   75.34%   75.29%   -0.05%     
==========================================
  Files         279      279              
  Lines       34368    34389      +21     
  Branches     5872     5878       +6     
==========================================
- Hits        25894    25893       -1     
- Misses       8474     8496      +22     
Flag Coverage Δ
libsinsp 75.29% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jan 31, 2025

Perf diff from master - unit tests

    11.88%     +1.13%  [.] sinsp::next
     2.79%     -0.70%  [.] sinsp_parser::process_event
     2.53%     +0.60%  [.] sinsp_thread_manager::find_thread
    10.35%     -0.47%  [.] sinsp_parser::reset
     1.62%     +0.37%  [.] std::_Hashtable<long, std::pair<long const, std::shared_ptr<sinsp_threadinfo> >, std::allocator<std::pair<long const, std::shared_ptr<sinsp_threadinfo> > >, std::__detail::_Select1st, std::equal_to<long>, std::hash<long>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::_M_find_before_node
     1.90%     -0.35%  [.] scap_event_decode_params
     3.78%     -0.32%  [.] gzfile_read
     3.20%     -0.26%  [.] sinsp_evt::load_params
     1.36%     -0.25%  [.] sinsp::fetch_next_event
     0.31%     +0.22%  [.] libsinsp::runc::match_one_container_id

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            +0.0300         +0.0300           147           151           147           151
BM_sinsp_split_median                                          +0.0317         +0.0317           146           151           146           151
BM_sinsp_split_stddev                                          -0.3575         -0.3575             1             1             1             1
BM_sinsp_split_cv                                              -0.3762         -0.3762             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  -0.0078         -0.0077            61            61            61            61
BM_sinsp_concatenate_paths_relative_path_median                -0.0159         -0.0158            61            60            61            60
BM_sinsp_concatenate_paths_relative_path_stddev                +0.9651         +0.9672             0             1             0             1
BM_sinsp_concatenate_paths_relative_path_cv                    +0.9804         +0.9826             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0035         -0.0035            24            24            24            24
BM_sinsp_concatenate_paths_empty_path_median                   -0.0057         -0.0057            24            24            24            24
BM_sinsp_concatenate_paths_empty_path_stddev                   +5.0441         +5.0428             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       +5.0654         +5.0641             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  -0.0437         -0.0438            67            64            67            64
BM_sinsp_concatenate_paths_absolute_path_median                -0.0440         -0.0440            67            64            67            64
BM_sinsp_concatenate_paths_absolute_path_stddev                -0.5350         -0.5347             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_cv                    -0.5137         -0.5134             0             0             0             0
BM_sinsp_split_container_image_mean                            +0.0037         +0.0037           391           393           391           393
BM_sinsp_split_container_image_median                          +0.0027         +0.0027           391           392           391           392
BM_sinsp_split_container_image_stddev                          -0.0215         -0.0216             3             3             3             3
BM_sinsp_split_container_image_cv                              -0.0251         -0.0251             0             0             0             0

@poiana poiana added size/S and removed size/XS labels Jan 31, 2025
@FedeDP
Copy link
Contributor Author

FedeDP commented Jan 31, 2025

Need to find correct multi arch docker images to be used by the tests!

Signed-off-by: Federico Di Pierro <[email protected]>
@FedeDP FedeDP force-pushed the chore/e2e_ci_arm64 branch from 5c1d8a1 to fbb168b Compare February 6, 2025 08:33
@poiana poiana added size/M and removed size/S labels Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

2 participants