Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(release): upgrade cosign-installer action to 3.3.0 #11

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

maxgio92
Copy link
Member

@maxgio92 maxgio92 commented Jan 4, 2024

Fixes #10

@maxgio92
Copy link
Member Author

maxgio92 commented Jan 4, 2024

/cc @FedeDP

@poiana poiana requested a review from leogr January 4, 2024 17:08
@poiana poiana added the approved label Jan 4, 2024
@maxgio92 maxgio92 changed the title ci(relaase/cosign): upgrade cosign-installer action to 3.3.0 ci(release/cosign): upgrade cosign-installer action to 3.3.0 Jan 4, 2024
@poiana poiana added the size/XS label Jan 4, 2024
@maxgio92
Copy link
Member Author

maxgio92 commented Jan 4, 2024

After this we need to release v0.2.0 as binary and OCI image.
cc @FedeDP

@maxgio92
Copy link
Member Author

maxgio92 commented Jan 4, 2024

See #13 to allow the CI to pass.
cc @FedeDP

@maxgio92 maxgio92 changed the title ci(release/cosign): upgrade cosign-installer action to 3.3.0 ci(release): upgrade cosign-installer action to 3.3.0 Jan 4, 2024
@FedeDP
Copy link
Contributor

FedeDP commented Jan 4, 2024

Will approve after the rebase!

@maxgio92
Copy link
Member Author

maxgio92 commented Jan 4, 2024

The PR is now ready @FedeDP, thank you!

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link

poiana commented Jan 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, maxgio92

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit e3a7c37 into falcosecurity:main Jan 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cosign installer fails during container image sigining in release pipeline
3 participants