Skip to content

Commit

Permalink
update(build): introduce the new engine_version_semver key for plugin…
Browse files Browse the repository at this point in the history
…s rule artifacts

Signed-off-by: Lorenzo Susini <[email protected]>
  • Loading branch information
loresuso committed Nov 2, 2023
1 parent 0c2f97b commit 25ca6ec
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
2 changes: 1 addition & 1 deletion build/registry/pkg/common/consts.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ const (
RulesArtifactSuffix = "-rules"
// EngineVersionKey is the name given to all the engine requirements.
// The same name used by Falco when outputting the engine version.
EngineVersionKey = "engine_version"
EngineVersionKey = "engine_version_semver"
// PluginAPIVersion is the name givet to the plugin api version requirements.
// The same name used by Falco when outputting the plugin api version
PluginAPIVersion = "plugin_api_version"
Expand Down
5 changes: 2 additions & 3 deletions build/registry/pkg/oci/requirements.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ import (
"errors"
"fmt"
"os"
"strconv"
"strings"

"github.com/blang/semver"
Expand Down Expand Up @@ -66,14 +65,14 @@ func rulesfileRequirement(filePath string) (*oci.ArtifactRequirement, error) {

// Split the requirement and parse the version to semVer.
tokens := strings.Split(fileScanner.Text(), ":")
reqVer, err := semver.ParseTolerant(tokens[1])
reqVer, err := semver.Parse(tokens[1])
if err != nil {
return nil, fmt.Errorf("unable to parse to semVer the version requirement %q", tokens[1])
}

return &oci.ArtifactRequirement{
Name: common.EngineVersionKey,
Version: strconv.FormatUint(reqVer.Major, 10),
Version: reqVer.String(),
}, nil
}

Expand Down

0 comments on commit 25ca6ec

Please sign in to comment.