Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cloudtrail): support s3 events #409

Merged

Conversation

matteopasa
Copy link
Contributor

@matteopasa matteopasa commented Feb 2, 2024

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area plugins

/area registry

/area build

/area documentation

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@poiana
Copy link
Contributor

poiana commented Feb 2, 2024

Welcome @matteopasa! It looks like this is your first PR to falcosecurity/plugins 🎉

@poiana poiana added the size/M label Feb 2, 2024
Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please remember to sign off your commits so that we can proceed with approving an merging. Thanks!

@poiana
Copy link
Contributor

poiana commented Feb 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jasondellaluce, matteopasa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor

poiana commented Feb 5, 2024

LGTM label has been added.

Git tree hash: 97f3ba62007c1d868612f36855b0dc9f574a3e8d

@poiana poiana added the approved label Feb 5, 2024
Copy link

github-actions bot commented Feb 5, 2024

Rules files suggestions

aws_cloudtrail_rules.yaml

Comparing 70b5651c623c8ef45b44e187e54d4e1eea5e541d with latest tag cloudtrail-0.10.0

No changes detected

@matteopasa matteopasa force-pushed the pasa/cloudtrail/support-s3-events branch from a14366f to b06e6b1 Compare February 5, 2024 10:15
@poiana poiana merged commit 7a9233d into falcosecurity:master Feb 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants