Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove s3 notification event extracted fields #414

Conversation

matteopasa
Copy link
Contributor

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area plugins

/area registry

/area build

/area documentation

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Signed-off-by: matteopasa <[email protected]>
Copy link

Rules files suggestions

aws_cloudtrail_rules.yaml

Comparing 3b63ce2a8df0261ffc5d41c358354932b3dd01f8 with latest tag cloudtrail-0.11.0

No changes detected

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

N.B.: this is ok since the plugin cannot process such events.

@poiana
Copy link
Contributor

poiana commented Feb 16, 2024

LGTM label has been added.

Git tree hash: ea48571eeff130e8ad9f9aefc419844a76c14f7a

@poiana
Copy link
Contributor

poiana commented Feb 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leogr, matteopasa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 29fa24d into falcosecurity:master Feb 16, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants