-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cloudtrail): Add generic additionalEventData field #418
Conversation
Rules files suggestionsaws_cloudtrail_rules.yamlComparing No changes detected |
/assign cc @Issif |
Similar to ct.request, all values should also be available for additionalEventData. Signed-off-by: Uli Heilmeier <[email protected]>
e5d9fac
to
3e18e8b
Compare
Rules files suggestionsaws_cloudtrail_rules.yamlComparing No changes detected |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thank you!
cc @LucaGuerra
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leogr, uhei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: 205aa81ee20fc8f23a1706899c71129550338b69
|
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area plugins
What this PR does / why we need it:
Similar to ct.request, all values should also be available for additionalEventData.