Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cloudtrail): support accounts for org trails #425

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

uhei
Copy link
Contributor

@uhei uhei commented Mar 7, 2024

What type of PR is this?

/kind feature

Any specific area of the project related to this PR?

/area plugins

What this PR does / why we need it:

Support accounts for organization trails. When open parameter is 's3://bucket_name/prefix_name/AWSLogs/O-ID/' and 'S3AccountList' is not set get all events for all accounts in the organization CloudTrail bucket.

If 'S3AccountList' is configured get events for the account IDs specified in the comma separated list.

S3Interval also works for organisation trails.

Which issue(s) this PR fixes:

Fixes #423

@poiana poiana requested review from leogr and mstemm March 7, 2024 11:06
@poiana poiana added the size/L label Mar 7, 2024
Copy link

github-actions bot commented Mar 7, 2024

Rules files suggestions

aws_cloudtrail_rules.yaml

Comparing 0bcfbee7c596f9258aa96f263575e0e56984bf12 with latest tag cloudtrail-0.11.0

No changes detected

@leogr
Copy link
Member

leogr commented Mar 8, 2024

cc @Issif

Copy link
Member

@Issif Issif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good, I've just some minor suggestions. To complete the changes, could you also update the version and the changelog please

Support accounts for organization trails. When open parameter is
's3://bucket_name/prefix_name/AWSLogs/O-ID/' and 'S3AccountList' is not set
get all events for all accounts in the organization CloudTrail bucket.

If 'S3AccountList' is configured get events for the account IDs specified
in the comma separated list.

S3Interval also works for organisation trails.

Fixes: falcosecurity#423

Signed-off-by: Uli Heilmeier <uh@heilmeier.eu>
@uhei uhei force-pushed the feat/org-accounts branch from 4c7b859 to 562e735 Compare March 12, 2024 07:53
@uhei
Copy link
Contributor Author

uhei commented Mar 12, 2024

Really good, I've just some minor suggestions. To complete the changes, could you also update the version and the changelog please

Thanks. I've changed the version.
Generating the changelog seems broken for cloudtrail. Should be fixed in an own commit.

Copy link

Rules files suggestions

aws_cloudtrail_rules.yaml

Comparing 5fd72ec23460099835cb55d0225b35e3aff150fe with latest tag cloudtrail-0.11.0

No changes detected

@leogr
Copy link
Member

leogr commented Mar 12, 2024

Thanks. I've changed the version.
Generating the changelog seems broken for cloudtrail. Should be fixed in an own commit.

cc @LucaGuerra @alacuku

@poiana
Copy link
Contributor

poiana commented Mar 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leogr, uhei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor

poiana commented Mar 12, 2024

LGTM label has been added.

Git tree hash: 2a2f6f8a6981a7355c2b56c744fcba83e5458229

@poiana poiana merged commit 9920d35 into falcosecurity:master Mar 12, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cloudtrail: Support for multiple accounts
4 participants