-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vote: add sboschman as approver for k8saudit-gke, and add the plugin to the registry #437
Conversation
The list of plugins is auto-generated from the BTW, as the original author of the plugin, I would recommend you to create an |
Signed-off-by: Sverre Boschman <[email protected]>
Rules files suggestions |
approvers: | ||
- sboschman |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per our governance adding a maintainer requires a majority vote
Eligible voters are @falcosecurity/plugins-maintainers
So
/hold until we get the majority or a week has passed
Ofc, +1 from me 👍
LGTM label has been added. Git tree hash: e3f8f18508af6906760d23338ec5d26b4448923c
|
We got the majority and also week has passed, so Welcome on board @sboschman 👏 We will take care of the procedure to set up your account as a maintainer. @sboschman meanwhile, could I just ask you to add yourself to this file? |
N.B. @sboschman you get an GitHub invitation to the falcosecurity organization once this PR gets merged. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jasondellaluce, leogr, sboschman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/verify-owners |
@Issif or @leogr , as we handed out plugin id 16 for
k8saudit-gke
, it might be useful to list it in the plugins readme