-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(plugins/github): add length check in if statement #439
Conversation
Signed-off-by: Sanja Kosier <[email protected]>
526a6f5
to
d2a7b9a
Compare
Rules files suggestionsgithub.yamlComparing No changes detected |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @SKosier
The change SGTM.
Could you just bump the plugin version to 0.7.1, please?
PluginVersion = "0.7.0" |
Signed-off-by: Sanja Kosier <[email protected]>
Rules files suggestionsgithub.yamlComparing No changes detected |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leogr, SKosier The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: a3678b4a9b93fcc44e3822b8639a272f2019588e
|
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
area plugins
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: