Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugins/github): add length check in if statement #439

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

SKosier
Copy link

@SKosier SKosier commented Mar 27, 2024

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

area plugins

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@poiana poiana added kind/bug Something isn't working dco-signoff: no labels Mar 27, 2024
@poiana poiana requested review from jasondellaluce and leogr March 27, 2024 11:52
@poiana poiana added the size/XS label Mar 27, 2024
Copy link

Rules files suggestions

github.yaml

Comparing d93d9b3de1ad8c5dd8dc5bef5c176d3884aa0781 with latest tag github-0.7.0

No changes detected

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @SKosier

The change SGTM.

Could you just bump the plugin version to 0.7.1, please?

PluginVersion = "0.7.0"

Signed-off-by: Sanja Kosier <[email protected]>
@poiana poiana added size/S and removed size/XS labels Mar 27, 2024
Copy link

Rules files suggestions

github.yaml

Comparing 61ba5419d9233182680349bd9ed2d5e52cd1c057 with latest tag github-0.7.0

No changes detected

@poiana
Copy link
Contributor

poiana commented Mar 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leogr, SKosier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor

poiana commented Mar 27, 2024

LGTM label has been added.

Git tree hash: a3678b4a9b93fcc44e3822b8639a272f2019588e

@poiana poiana merged commit 2ec47c4 into falcosecurity:master Mar 27, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants