update(CI): change release tag format #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leogr
reviewed
Apr 11, 2024
There was a problem hiding this comment.
Could we update the doc 👇 as well, please?
https://github.com/falcosecurity/plugins/blob/main/release.md#tag-format-stable-build-only
leogr
reviewed
Apr 11, 2024
| @@ -18,14 +18,13 @@ jobs: | |||
| package: ${{ steps.regex-match.outputs.group1 }} | |||
|
|
|||
| steps: | |||
| - name: Extract semver ℹ️ | |||
| - name: Validate tag ℹ️ | |||
There was a problem hiding this comment.
I guess it was a leftover. I recommend to clean it up, eventually
leogr
reviewed
Apr 11, 2024
alacuku
force-pushed
the
klc/ci-change-tag-format
branch
3 times, most recently
from
b1484db to
863a292
Compare
Signed-off-by: Aldo Lacuku <[email protected]>
alacuku
force-pushed
the
klc/ci-change-tag-format
branch
from
863a292 to
c57b11d
Compare
leogr
approved these changes
Apr 12, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alacuku, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: 2527855429d9a4757d551926b9cf466303c25808
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Any specific area of the project related to this PR?
/area build
What this PR does / why we need it:
See #223
Which issue(s) this PR fixes:
Fixes #223
Special notes for your reviewer:
@falcosecurity/plugins-maintainers Please note that once this PR gets merged, you will need to use the new tag format to release a plugin!