Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests/falcoctl): updated tests to latest main output. #33

Merged

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Nov 28, 2023

Latest main output is a bit different:

2023-11-28 09:42:13 INFO  Resolving dependencies ... 
2023-11-28 09:42:14 INFO  Installing artifacts
                      └ refs: [ghcr.io/falcosecurity/plugins/plugin/dummy:latest]
2023-11-28 09:42:14 INFO  Preparing to pull artifact
                      └ ref: ghcr.io/falcosecurity/plugins/plugin/dummy:latest
2023-11-28 09:42:14 INFO  Pulling layer ff06a0d6ed4f 
2023-11-28 09:42:14 INFO  Pulling layer 1adcd4b01f59
2023-11-28 09:42:14 INFO  Pulling layer 5b7f12491641 
2023-11-28 09:42:14 INFO  Extracting and installing artifact
                      ├ type: plugin
                      └ file: dummy-0.9.1-linux-x86_64.tar.gz
2023-11-28 09:42:14 INFO  Artifact successfully installed
                      ├ name: ghcr.io/falcosecurity/plugins/plugin/dummy:latest
                      ├ type: plugin
                      ├ digest: sha256:5b7f1249164115be3b51f226d931230ef129c3e54143b30be2b07c59a034f46b
                      └ directory: /tmp/falcosecurity-testing-workdir-264431649/plugins\n

Ensure compatibility with newer output while retaining backward compatibility (only searching for Artifact successfully installed string).

@FedeDP
Copy link
Contributor Author

FedeDP commented Nov 28, 2023

This should help fixing a couple of test failing in falcosecurity/falco#2905

@poiana
Copy link

poiana commented Nov 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, jasondellaluce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 5df15a1 into falcosecurity:main Nov 28, 2023
1 check passed
@FedeDP FedeDP deleted the chore/update_falcoctl_latest_output branch November 29, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants