Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate existing inputs to vuetify #380

Merged

Conversation

rossicler
Copy link
Contributor

Proposed Changes

It was migrated the text inputs of the project to vuetify. #378

Type of Changes

What type of change this Pull Request brings to Falko?

  • Bugfix
  • New Feature

Checklist

  • This Pull Request has a significant name.
  • The build is okay (tests, code climate).
  • This Pull Request mentions a related issue.

@MatheusRich
Copy link
Member

@rossicler It seems that you're updating all the buttons too, but it was also addressed on #379.

This reverts commit 44e7e4f.
@rossicler
Copy link
Contributor Author

@rossicler It seems that you're updating all the buttons too, but it was also addressed on #379.

Thanks for the reply, I reverted the merge commit of the buttons migration.

Copy link
Member

@MatheusRich MatheusRich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems to be good. Please fix the conflicts in package.json

@@ -129,12 +128,12 @@ export default {
max-width: 20em;
}

#registerForm input {
/* #registerForm input {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still used?

@@ -155,14 +161,14 @@ export default {

<style scoped>

textarea {
/* textarea {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this still being used?

@@ -72,13 +72,13 @@ export default {
</script>

<style scoped>
input {
/* input {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

@@ -66,13 +66,13 @@ export default {
</script>

<style scoped>
input {
/* input {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

@rossicler
Copy link
Contributor Author

this seems to be good. Please fix the conflicts in package.json

Conflict resolved, also deleted the commented unused css.

@MatheusRich
Copy link
Member

MatheusRich commented Oct 18, 2019

@alaxalves @MartinsLucas can you guys take a look at this?

@MatheusRich MatheusRich merged commit 44970fc into falko-org:devel Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants