-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A 2.0.0 release, please? #113
Open
loegering
wants to merge
132
commits into
fangyidong:master
Choose a base branch
from
cliftonlabs:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 8. Serialize honors its flags in sub calls in all circumstances.
…r section in README.txt
…oy process in the README.txt.
…Labs and Fang Yidong.
…ss is/was granted instead.
…eployment settings.
…a get for each JSON value. JsonObject tests updated.
Support for JsonKey parameter for put and putChain operations
…tag of the javadocs.
…w explicitly states the current default: %pack. The yychar/position variable is now a long instead of an int. This required changing JsonException to use a long too.
…n class to ensure compatibility with projects that do more advanced JsonException handling.
…r writer instead of the convenience methods that generate their own.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've really enjoyed how this library handles JSONArrays and JSONObjects but sorely miss generics and other nice to have features.
I've forked your library to address all of the issues submitted to your repository. It features generics and a clean API at the cost of losing support for java 2 to 6. Its APIs are otherwise 100% backwards compatible in projects using java 7+ so version 2.3.1 can be dropped in to replace 1.1.1 without any damage to the project. The only real work you'd have to do is update the POM to match the old maven coordinates and it would be ready for a 2.0 release to the maven repositories.
See https://cliftonlabs.github.io/json-simple/ for more details about this fork. I would also be willing to do the maintenance necessary to publish these changes for/with you. If you accept these changes, I think those following this project would appreciate them. Thanks so far for a great JSON library!