Fixes #10 - Make sure object header is an int #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also removes trailing whitespace farcaller#10
farcaller
requested changes
Nov 18, 2020
| def __getObjHeader(self, offset): | ||
| obj_header = self.data[offset] | ||
|
|
||
| if type(obj_header) == str: |
There was a problem hiding this comment.
I'm pretty sure we don't need that check because the BPlistReader() expects an str as input.
There was a problem hiding this comment.
So reading from string never worked or something changed in python2?
There was a problem hiding this comment.
It's a tricky question to answer now, given I never wrote unit tests for this :-)
I'm pretty sure all codepaths used to work, but I went back to python 2.5 and it's still a problem there. This package is clearly not the most popular one so maybe it was a bug all these years.
There was a problem hiding this comment.
In that case, I feel like it's safer to leave the check in there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removes trailing whitespace
#10