Skip to content

Commit

Permalink
chore
Browse files Browse the repository at this point in the history
  • Loading branch information
farhan committed Aug 19, 2024
1 parent 67227c0 commit ca60489
Showing 1 changed file with 31 additions and 8 deletions.
39 changes: 31 additions & 8 deletions .github/workflows/bulk_issue_creator.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,6 @@ on:
description: "List of repositories in the format 'x', 'y', 'z'..."
type: string
required: true
issue_title:
description: 'Issue title. WARNING: Replace all backticks (`) with escaped backticks (\`)'
type: string
required: true
issue_description:
description: 'Issue description. WARNING: Replace all backticks (`) with escaped backticks (\`)'
type: string
required: true
issue_labels:
description: "List of labels in the format 'x', 'y', 'z'..."
type: string
Expand Down Expand Up @@ -62,6 +54,32 @@ jobs:
path: issue_list.*

bulk_issue_creation:
env:
ISSUE_TITLE_VAR: |
Move on from deprecated `pkg_resources` api
ISSUE_DESCRIPTION_VAR: |
Shift the code from `pkg_resources` to `importlib.resources` api
Migration guide: https://importlib-resources.readthedocs.io/en/latest/migration.html
Decision making story: https://github.com/openedx/XBlock/issues/676
Reference PR to take learning from: https://github.com/openedx/xblock-sdk/pull/350/files
**Prerequisites:**
- Support of python 3.8 should be dropped. [Relevant epic](https://github.com/openedx/public-engineering/issues/274)
**Acceptance Criteria:**
- Make sure the repository is using xblock version 5.0.0 or above. Upgrade the version if required, preferably via the make upgrade command.
- There should be no usage of `pkg_resources` in the repository
- Test cases should be passed
- XBlock should perform all of its functionality related to change (loading resources)
```[tasklist]
### Tasks
- [x] xblock https://github.com/openedx/XBlock/issues/676
- [x] feedback-xblock https://github.com/openedx/FeedbackXBlock/pull/58
- [ ] xblock-sdk https://github.com/openedx/xblock-sdk/pull/350
```
runs-on: ubuntu-20.04
needs: [ prepare_repos_list, create_issue_list_files ]
strategy:
Expand All @@ -77,9 +95,14 @@ jobs:
name: issues-artifact
- name: Create Issue in ${{ matrix.repo }}
run: |
<<<<<<< Updated upstream
# Safely handle issue title and body
issue_title="${{ github.event.inputs.issue_title }}"
issue_body="${{ github.event.inputs.issue_description }}"
=======
issue_title="$ISSUE_TITLE_VAR"
issue_body="$ISSUE_DESCRIPTION_VAR"
>>>>>>> Stashed changes
labels_string=["${{ github.event.inputs.issue_labels }}"]
labels_array=$(echo "$labels_string" | sed "s/'/\"/g" | jq -c .)

Expand Down

0 comments on commit ca60489

Please sign in to comment.