Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Schema utility functions such as omit, pick, and partial to preserve the recursive capability of ObjectType, while adding a required utility function. #198

Merged
merged 2 commits into from
Jan 20, 2025

Conversation

AisonSu
Copy link
Contributor

@AisonSu AisonSu commented Jan 15, 2025

Refactor Schema utility functions such as omit, pick, and partial to preserve the recursive capability of ObjectType, while adding a required utility function.

…and required functionalities with preserve the recursive capability of ObjectType
Copy link
Collaborator

@Lucifier129 Lucifier129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some test-cases for this change, especially for formatter/validator.

… has been modified, and relevant tests for the required utility function have been added.
@AisonSu
Copy link
Contributor Author

AisonSu commented Jan 18, 2025

Please add some test-cases for this change, especially for formatter/validator.

Thanks for the reminder! I've already added test cases for the formatter and validator, and all tests have passed successfully. Let me know if you need any further adjustments or additional test coverage.

@Lucifier129
Copy link
Collaborator

LGTM

@Lucifier129 Lucifier129 merged commit e0dbc06 into farrow-js:master Jan 20, 2025
@Lucifier129
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants