Imported OpenID Connect support from Heviat #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fastlorenzo
pushed a commit
that referenced
this pull request
Dec 6, 2022
2542: Implement header authentication via external proxy r=mergify[bot] a=nextgens ## What type of PR? Feature ## What does this PR do? Implement header authentication via external proxy ### Related issue(s) - closes Mailu#1972 - closes Mailu#2183 ## Prerequisites Before we can consider review and merge, please make sure the following list is done and checked. If an entry in not applicable, you can check it or remove it from the list. - [x] In case of feature or enhancement: documentation updated accordingly - [x] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/workflow.html#changelog) entry file. 2559: Turns out that php81-ctype is required by roundcube r=mergify[bot] a=nextgens ## What type of PR? bug-fix ## What does this PR do? It solves: ``` [25-Nov-2022 08:19:20] WARNING: [pool php] child 335 said into stderr: "NOTICE: PHP message: PHP Fatal error: Uncaught Error: Call to undefined function Masterminds\HTML5\Parser\ctype_alpha() in /var/www/roundcube/vendor/masterminds/html5/src/HTML5/Parser/Tokenizer.php:140" [25-Nov-2022 08:19:20] WARNING: [pool php] child 335 said into stderr: "Stack trace:" [25-Nov-2022 08:19:20] WARNING: [pool php] child 335 said into stderr: "#0 /var/www/roundcube/vendor/masterminds/html5/src/HTML5/Parser/Tokenizer.php(82): Masterminds\HTML5\Parser\Tokenizer->consumeData()" [25-Nov-2022 08:19:20] WARNING: [pool php] child 335 said into stderr: "#1 /var/www/roundcube/vendor/masterminds/html5/src/HTML5.php(161): Masterminds\HTML5\Parser\Tokenizer->parse()" [25-Nov-2022 08:19:20] WARNING: [pool php] child 335 said into stderr: "#2 /var/www/roundcube/vendor/masterminds/html5/src/HTML5.php(89): Masterminds\HTML5->parse('<html>\n <hea...', Array)" [25-Nov-2022 08:19:20] WARNING: [pool php] child 335 said into stderr: "Mailu#3 /var/www/roundcube/program/lib/Roundcube/rcube_washtml.php(700): Masterminds\HTML5->loadHTML('<html>\n <hea...')" [25-Nov-2022 08:19:20] WARNING: [pool php] child 335 said into stderr: "Mailu#4 /var/www/roundcube/program/actions/mail/index.php(975): rcube_washtml->wash('<html>\n <hea...')" [25-Nov-2022 08:19:20] WARNING: [pool php] child 335 said into stderr: "Mailu#5 /var/www/roundcube/program/actions/mail/index.php(1019): rcmail_action_mail_index::wash_html('<!doctype html>...', Array, Array)" [25-Nov-2022 08:19:20] WARNING: [pool php] child 335 said into stderr: "Mailu#6 /var/www/roundcube/program/actions/mail/show.php(720): rcmail_action_mail_index::pr..." ``` see roundcube/roundcubemail#7049 Co-authored-by: Florent Daigniere <[email protected]>
Signed-off-by: fastlorenzo <[email protected]>
Signed-off-by: fastlorenzo <[email protected]>
2580: Fixed roundcube carddav module r=mergify[bot] a=fastlorenzo ## What type of PR? bug-fix ## What does this PR do? This makes the Carddav module of roundcube to work again. Changes made: - Add 2 missing packages in the container (`php81-xmlreader` and `php81-xmlwriter`) - Disable one rule in snuffleupagus that blocked the web request needed from the plugin to interact with carddav Co-authored-by: fastlorenzo <[email protected]>
2581: fix missing casting to int for SESSION_KEY_BITS r=nextgens a=fastlorenzo ## What type of PR? bug-fix ## What does this PR do? This PR adds a missing env var casting for the `SESSION_KEY_BITS` variable. When trying to provide a different value via env var, the value is passed as a string and then compared to a int. The following check then throws a cast error: https://github.com/Mailu/Mailu/blob/50c7fa882e0a2cea57cecdd4b9c89bba13362f5a/core/admin/mailu/utils.py#L309-L312 ### Related issue(s) ## Prerequisites Before we can consider review and merge, please make sure the following list is done and checked. If an entry in not applicable, you can check it or remove it from the list. Co-authored-by: fastlorenzo <[email protected]>
Signed-off-by: fastlorenzo <[email protected]>
Signed-off-by: fastlorenzo <[email protected]>
Signed-off-by: fastlorenzo <[email protected]>
Signed-off-by: fastlorenzo <[email protected]>
Signed-off-by: fastlorenzo <[email protected]>
Signed-off-by: fastlorenzo <[email protected]>
Signed-off-by: fastlorenzo <[email protected]>
Signed-off-by: fastlorenzo <[email protected]>
Signed-off-by: fastlorenzo <[email protected]>
Signed-off-by: fastlorenzo <[email protected]>
Signed-off-by: fastlorenzo <[email protected]>
Signed-off-by: fastlorenzo <[email protected]>
Signed-off-by: fastlorenzo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Imported OpenID Connect support from Heviat