Use canonical string representation for IPv6 addresses #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Net::IP::ip returns the expanded representation for IPv6 addresses (from ip_expand_address), whereas Net::IP::short returns the compressed representation (from ip_compress_address) recommended by RFC 5952. Per section 4, "The recommendation in this section SHOULD be followed by systems when generating an address to be represented as text."[1] Net::IP::ip and Net::IP::short return the same value for single IPv4 addresses, however they may return different values for IPv4 prefixes. The code affected by this change only deals with single addresses so there is no change to the representation of IPv4 addresses. [1] https://datatracker.ietf.org/doc/html/rfc5952#section-4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Net::IP::ip returns the expanded representation for IPv6 addresses (from ip_expand_address), whereas Net::IP::short returns the compressed representation (from ip_compress_address) recommended by RFC 5952. Per section 4, "The recommendation in this section SHOULD be followed by systems when generating an address to be represented as text."[1]
Net::IP::ip and Net::IP::short return the same value for single IPv4 addresses, however they may return different values for IPv4 prefixes. The code affected by this change only deals with single addresses so there is no change to the representation of IPv4 addresses.
[1] https://datatracker.ietf.org/doc/html/rfc5952#section-4