Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error out if the lookup fails #5

Merged
merged 2 commits into from
Jun 11, 2024
Merged

error out if the lookup fails #5

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f647f2
error out if the lookup fails
bigio May 22, 2024
a7be350
use "try" instead of "eval"
bigio May 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions lib/Mail/SPF/Server.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -570,11 +570,16 @@ sub dns_lookup {

$domain =~ s/^(.*?)\.?$/\L$1/; # Normalize domain.

my $packet = $self->dns_resolver->send($domain, $rr_type);
try {
$packet = $self->dns_resolver->send($domain, $rr_type);
}
otherwise {
throw Mail::SPF::ENoAcceptableRecord($self->dns_resolver->errorstring);
};

# Throw DNS exception unless an answer packet with RCODE 0 or 3 (NXDOMAIN)
# was received (thereby treating NXDOMAIN as an acceptable but empty answer packet):
$self->dns_resolver->errorstring !~ /^(timeout|query timed out)$/
defined $self->dns_resolver->errorstring and $self->dns_resolver->errorstring !~ /^(timeout|query timed out)$/
or throw Mail::SPF::EDNSTimeout(
"Time-out on DNS '$rr_type' lookup of '$domain'");
defined($packet)
Expand Down