Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto pick current version from go.mod in goreleaser.yml #3594

Closed
wants to merge 2 commits into from
Closed

Auto pick current version from go.mod in goreleaser.yml #3594

wants to merge 2 commits into from

Conversation

kevincobain2000
Copy link

Summary

Updates goreleaser.yml to auto pick go version from go.mod

WHY

Related to #3573, so you don't have to change the version each time when go.mod is changed.

I also considered updating golangci-lint.yml and add a matrix as below:

jobs:
  golangci:
    strategy:
      matrix:
        go-version: [mod, latest]
        os: [ubuntu-latest, macos-latest]

That will auto pick up go version from go.mod and the latest version that is released. But wasn't sure if you are trying to limit the number of jobs and wasn't on matrix for a special reason.

Action is using https://github.com/kevincobain2000/gobrew for more information.

@kevincobain2000 kevincobain2000 changed the title Auto pick version from go.mod. https://github.com/fatedier/frp/pull/3573 Auto pick current version from go.mod in goreleaser.yml Aug 31, 2023
@fatedier
Copy link
Owner

The version we are compiling with does not match the one specified in go.mod.

Furthermore, I prefer to explicitly specify major versions.

@kevincobain2000
Copy link
Author

Sure. Fair enough.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants