replace not nil check on nil value

replace not nil check on nil value replace not nil check on nil value
fatfreecrm · Dec 5, 2023 · 2539d20 · 2539d20
1 parent 7c13e93
commit 2539d20
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/app/models/setting.rb b/app/models/setting.rb
@@ -58,9 +58,9 @@ def [](name)
       return cache[name] if cache.key?(name)
 
       # Check database
-      if database_and_table_exists? && setting = find_by_name(name.to_s) && !setting.value.nil?
+      if database_and_table_exists? && (setting = find_by_name(name.to_s))&.value.present?
         return cache[name] = setting.value
-        end
+      end
       # Check YAML settings
       return cache[name] = yaml_settings[name] if yaml_settings.key?(name)
     end