New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix formatting base URL #1316

Merged

steveyken merged 1 commit into fatfreecrm:master from stanleylhs:fix-base-url

Aug 7, 2024

Member

stanleylhs commented Aug 6, 2024 •

edited

Loading

Non-escaped base url is breaking the footer javascript.
Escaped to make JS work again.


          Fix formatting base URL

cb4ab0d

stanleylhs requested a review from steveyken

August 6, 2024 10:54

steveyken approved these changes

View reviewed changes

Member

steveyken commented Aug 7, 2024

Confirming that prior to this fix, base_url in the javascript footer would format improperly

crm.base_url = 'http://localhost:3001/ffcrm';

After this fix, the base_url formats correctly as

crm.base_url = 'http://localhost:3001/ffcrm';

steveyken merged commit a450964 into fatfreecrm:master

8 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet