Use the inc, dec to vector functions in RTP filter #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reduction-to-the-pole filter in the frequency domain did these conversions inside it before we had the dedicated functions. Replace that code with `magnetic_angles_to_vec` to simplify the code and remove the auxiliary function that was used. Revised the docstring and removed the conversion step since it's not done in this function anymore.
|
Was going through the code today for a class and noticed this. Always feels good to delete some code 🙂 |
leouieda
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reduction-to-the-pole filter in the frequency domain did these conversions inside it before we had the dedicated functions. Replace that code with
magnetic_angles_to_vecto simplify the code and remove the auxiliary function that was used. Revised the docstring and removed the conversion step since it's not done in this function anymore.