Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS-2783] Replace ServiceTimeoutError with QueryTimeoutError #270

Merged
merged 2 commits into from
May 22, 2024

Conversation

jrodewig
Copy link
Contributor

@jrodewig jrodewig commented May 22, 2024

Ticket(s): DOCS-2783

Problem

With #252, the JS driver merged the ServiceTimeoutError class into the QueryTimeoutError class. I think this was a typo anyway.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jrodewig jrodewig requested a review from ptpaterson May 22, 2024 21:20
Copy link
Contributor

@ptpaterson ptpaterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good catch. Thanks!

@ptpaterson ptpaterson enabled auto-merge (squash) May 22, 2024 22:38
@ptpaterson ptpaterson merged commit 50204f7 into main May 22, 2024
5 checks passed
@ptpaterson ptpaterson deleted the update-js-driver-timeout-errors branch May 22, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants