This repository has been archived by the owner on Jun 2, 2022. It is now read-only.
[iOS] using only *.h, *.m and *.swift files as sources #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes fayeed#22 Inspiered from fayeed#22 (comment) workaround
|
I have added the old SDK files that you removed in v1.3.0 (using git source instead). This is a quick fix (rollback) that works, so I again suggest merge, bump and publish to pub.dev. Since the latest version on it is having a lot of issue #34 Meanwhile I am also working on getting Freshchat-v3.4.0 SDK with git source. Will file a PR which is working both in release and development. |
|
Check comparison of this PR agains the v1.2.6 that was published in pub.dev for clarity: 5475c11...daadu:master |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22 #34
Inspiered from #22 (comment) workaround