Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake interface library #21

Merged
merged 2 commits into from
Dec 9, 2020
Merged

cmake interface library #21

merged 2 commits into from
Dec 9, 2020

Conversation

plusk01
Copy link
Contributor

@plusk01 plusk01 commented Dec 9, 2020

This PR "modernizes" the cmake build process:

  1. marks the plot header files as interface includes so that cmake targets using target_link_libraries automatically pull in the headers (used here)
  2. optionally disables building the applications -- useful when plot is included in a superbuild (used here)

Thanks for the cool plotting library. Would love to see more features be added (e.g., axes, legends, etc.). FYI, I'm using this library here (with eigen).

@fbbdev fbbdev merged commit ac9c4dc into fbbdev:master Dec 9, 2020
@fbbdev
Copy link
Owner

fbbdev commented Dec 9, 2020

Hi,

thank you for the PR. As you can see from open issues, proper plotting features (axes, scaling, etc.) have been on the roadmap since long ago.

The reason I stopped at the time was that I didn't yet have a clear idea about how to design a clean, usable API.

Unfortunately I just don't have any time to work on this, but proposals, discussions under #15 and #16 and eventually PRs are very welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants