Eslint (FAForever#498)

add eslint
fcaps · Nov 27, 2023 · 9d5de76 · 9d5de76
1 parent 373b885
commit 9d5de76
Show file tree

Hide file tree

Showing 10 changed files with 932 additions and 312 deletions.
diff --git a/.eslintrc b/.eslintrc
@@ -0,0 +1,7 @@
+{
+  "root": true,
+  "extends": ["standard"],
+  "rules": {
+    "indent": ["error", 4]
+  }
+}
diff --git a/.github/workflows/code-quality.yml b/.github/workflows/code-quality.yml
@@ -16,8 +16,8 @@ jobs:
         node-version: '20'
         cache: 'yarn'
     - run: yarn install
-    # --force should be removed if all the issues are fixed
-    - run: ./node_modules/.bin/grunt jshint --force
     - run: npx webpack
+    - run: yarn run lint
+      continue-on-error: true # should be removed if all the issues are fixed
     - run: yarn run test
     - uses: codecov/codecov-action@v3
diff --git a/.jshintrc b/.jshintrc
diff --git a/.npmcheckrc b/.npmcheckrc
@@ -9,8 +9,5 @@ depcheck:
     "grunt-postcss",
     "grunt-nodemon",
     "grunt-contrib-watch",
-    "grunt-contrib-uglify-es",
-    "grunt-contrib-jshint",
-    "grunt-contrib-concat",
     "grunt-concurrent"
   ]
diff --git a/grunt/jshint.js b/grunt/jshint.js
diff --git a/package.json b/package.json
@@ -27,16 +27,19 @@
   "devDependencies": {
     "awesomplete": "^1.1.5",
     "dart-sass": "^1.25.0",
+    "eslint": "^8.54.0",
+    "eslint-config-standard": "^17.1.0",
+    "eslint-plugin-import": "^2.29.0",
+    "eslint-plugin-n": "^16.3.1",
+    "eslint-plugin-promise": "^6.1.1",
     "grunt": "1.6.1",
     "grunt-concurrent": "3.0.0",
-    "grunt-contrib-jshint": "^3.2.0",
     "grunt-contrib-watch": "^1.1.0",
     "grunt-nodemon": "^0.4.2",
     "grunt-postcss": "0.9.0",
     "grunt-run": "^0.8.1",
     "grunt-sass": "3.1.0",
     "jest": "^29.7.0",
-    "jshint-stylish": "2.2.1",
     "load-grunt-config": "4.0.1",
     "load-grunt-tasks": "5.1.0",
     "octokit": "^3.1.2",
@@ -51,6 +54,8 @@
   },
   "scripts": {
     "start": "node express.js",
-    "test": "jest"
+    "test": "jest",
+    "lint": "eslint --ignore-path .gitignore src tests",
+    "lint:fix": "eslint --fix --ignore-path .gitignore src tests"
   }
 }
diff --git a/src/backend/.eslintrc b/src/backend/.eslintrc
@@ -0,0 +1,6 @@
+{
+    "env": {
+        "node": true,
+        "es2020": true
+    }
+}
diff --git a/src/frontend/js/.eslintrc b/src/frontend/js/.eslintrc
@@ -0,0 +1,6 @@
+{
+  "env": {
+    "browser": true,
+    "es2020": true
+  }
+}
diff --git a/tests/.eslintrc b/tests/.eslintrc
@@ -0,0 +1,8 @@
+{
+  "env": {
+    "es2020": true,
+    "node": true,
+    "jest": true,
+    "jasmine": true
+  }
+}