feat: retry command in minutes

Change retry_send_to_financial_manager Django command to retry_in_minutes to be more similar than other projects commands.
fccn · Apr 19, 2024 · e6ec930 · e6ec930
1 parent 1ec58b9
commit e6ec930
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 7 deletions.
diff --git a/nau_extensions/management/commands/retry_send_to_financial_manager.py b/nau_extensions/management/commands/retry_send_to_financial_manager.py
@@ -24,6 +24,9 @@ class Command(BaseCommand):
     the Financial Manager system.
     By default, will retry the BasketTransactionIntegration objects where its state is sent with
     error and also send the pending to be sent that have been created more than 5 minutes ago.
+
+    Example to retry last 24 hours:
+      python manage.py retry_send_to_financial_manager --delta_in_minutes=1440
     """
 
     help = (
@@ -36,7 +39,7 @@ def add_arguments(self, parser):
         """
         Arguments to this Django Command.
         `basket_id` to run for a specific Basket;
-        `delta_to_be_sent_in_seconds` to run all failed and pending on this time frame.
+        `delta_in_minutes` to run all failed and pending on this time frame.
         """
         parser.add_argument(
             "--basket_id",
@@ -45,7 +48,7 @@ def add_arguments(self, parser):
             help="Basket id to synchronize, otherwise all pending baskets will be sent",
         )
         parser.add_argument(
-            "--delta_to_be_sent_in_seconds",
+            "--delta_in_minutes",
             type=int,
             default=300,
             help="Delta in seconds to retry",
@@ -77,11 +80,11 @@ def handle(self, *args, **kwargs):
                 ]
             )
 
-        delta_to_be_sent_in_seconds = kwargs["delta_to_be_sent_in_seconds"]
+        delta_in_minutes = kwargs["delta_in_minutes"]
         retry_success_count = 0
         for bti in btis:
             if bti.created <= datetime.now(bti.created.tzinfo) - timedelta(
-                seconds=delta_to_be_sent_in_seconds
+                minutes=delta_in_minutes
             ):
                 log.info("Sending to financial manager basket_id=%d", bti.basket.id)
                 sent = send_to_financial_manager_if_enabled(bti)

diff --git a/nau_extensions/tests/test_command_retry_send_to_financial_manager.py b/nau_extensions/tests/test_command_retry_send_to_financial_manager.py
@@ -33,7 +33,7 @@ def test_retry_send_to_financial_manager_once(self, send_mock):
         )
         bti_pending = self._create_basket_transaction_integration()
 
-        call_command("retry_send_to_financial_manager", delta_to_be_sent_in_seconds=0)
+        call_command("retry_send_to_financial_manager", delta_in_minutes=0)
         send_mock.assert_called_once_with(bti_pending)
 
     def test_retry_send_to_financial_manager_one_each_state(self, send_mock):
@@ -53,7 +53,7 @@ def test_retry_send_to_financial_manager_one_each_state(self, send_mock):
         bti_error.state = BasketTransactionIntegration.SENT_WITH_ERROR
         bti_error.save()
 
-        call_command("retry_send_to_financial_manager", delta_to_be_sent_in_seconds=0)
+        call_command("retry_send_to_financial_manager", delta_in_minutes=0)
         self.assertEqual(send_mock.call_count, 2)
 
     def test_retry_send_to_financial_manager_multiple(self, send_mock):
@@ -62,5 +62,5 @@ def test_retry_send_to_financial_manager_multiple(self, send_mock):
         """
         for _ in range(10):
             self._create_basket_transaction_integration()
-        call_command("retry_send_to_financial_manager", delta_to_be_sent_in_seconds=0)
+        call_command("retry_send_to_financial_manager", delta_in_minutes=0)
         self.assertEqual(send_mock.call_count, 10)