Fix icon name mapping in flatpak #1049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now we have a much of icons that uses "fcitx_" as the name, including mozc, skk, kkc, rime, to avoid xdg icon spec based fallback. But we missed the flatpak naming mapping for those icons. Update the condition here, and also handle the special name "fcitx" (I don't think we do have code that uses "fcitx" as icon, but well.. ) fcitx/mozc#53 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we have a much of icons that uses "fcitx_" as the name, including mozc, skk, kkc, rime, to avoid xdg icon spec based fallback.
But we missed the flatpak naming mapping for those icons. Update the condition here, and also handle the special name "fcitx" (I don't think we do have code that uses "fcitx" as icon, but well.. )
fcitx/mozc#53 (comment)