Changed recipe3 and added recipe5 in chapter 4. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Recipe3 - Passing Configuration Params to Filters" as described in the book does not match the repo's source code. "Recipe5 - Chaining Filters together" is missing. Even though the author explicitly says "I leave the implementation of the sortAscending filter as an exercise to the reader...", the source code of the recipe should be in the repo. Just like the rest of the examples. Kept the implementation of the sortAscendingFilter as simple as possible. The previous recipe3 is now recipe4. The previous recipe4 is now recipe6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Recipe3 - Passing Configuration Params to Filters" as described in
the book does not match the repo's source code.
"Recipe5 - Chaining Filters together" is missing. Even though the author
explicitly says "I leave the implementation of the sortAscending filter
as an exercise to the reader...", the source code of the recipe should be
in the repo. Just like the rest of the examples.
Kept the implementation of the sortAscendingFilter as simple as possible.
The previous recipe3 is now recipe4.
The previous recipe4 is now recipe6.