Dit is mijn opgeleverde werk voor de code en design review. #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rinux55
reviewed
Jan 25, 2024
There was a problem hiding this comment.
Hi Yu Jing,
Ik heb de volgende punten voor je:
- Heel goed dat je in een vroeg stadium feedback hebt gevraagd!
- Je kan je afbeeldingen dezelfde grootte maken met
object-fit - Zorg dat je je grid goed toepast bij de afbeeldingen
- Hier en daar klopt de uitlijning niet helemaal. Zie bijv. het Funda logo. Gezien dat een van de eerste dingen is die we zien, staat dat een beetje slordig.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ik heb de feedback gelezen en ben er mee aan de slag gegaan en dit is het eindresultaat.
@rinux55 and @larsdouweschuitema