Pull Request Funda project #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rinux55
reviewed
Jan 25, 2024
There was a problem hiding this comment.
Hi Rutger,
Afgezien van de comment heb ik nog een paar puntjes:
- let op de uitlijning van de elementen. Met
flexkan je heel makkelijk elementen centreren. - je hebt grid toegepast, maar er zijn nog verbeteringen in te maken. Zo kan je bij de afbeeldingen de hoofd-afbeelding kunnen spreiden over 4 kolommen
- Het makelaarsblok mist.
Verder goed werk afgeleverd!
| <div id="form_container"> | ||
| <form> | ||
| <div> | ||
| <label>Postcode</label> |
There was a problem hiding this comment.
Zorg ervoor dat je input een id hebben, dan kan je je label via een for attribute linken aan dat input. Zo kunnen assistive tools een juiste naam geven aan het element.
| </a> | ||
| </div> | ||
| <div id="tablet_nav"> | ||
| <details name="name" class="tablet_nav_details"> |
There was a problem hiding this comment.
Probeer één navigatie te hebben en deze aan te passen met css om het responsive te maken. Nu heb je verschillende secties voor verschillende screen sizes, dat maakt het weer moeilijker te onderhouden en/of aan te passen.
| <img src="assets/Logo.svg" alt="Funda Logo"> | ||
| </a> | ||
| <div id="mobile_nav"> | ||
| <details> |
There was a problem hiding this comment.
waarom gebruik je hier een <details> element?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@larsdouweschuitema @rinux55