fix publish, versions issue

Signed-off-by: Tommy Hughes <[email protected]>
feast-dev · Jan 21, 2025 · 6d9d4ac · 6d9d4ac
1 parent 9e1b4db
commit 6d9d4ac
Showing 1 changed file with 9 additions and 14 deletions.
diff --git a/.github/workflows/publish_images.yml b/.github/workflows/publish_images.yml
@@ -24,23 +24,21 @@ on:
         type: string
 
 jobs:
-  get-version:
-    uses: ./.github/workflows/get_semantic_release_version.yml
-    with:
-      custom_version: ${{ github.event.inputs.custom_version }}
-      token: ${{ github.event.inputs.token }}
-
   build-publish-docker-images:
     if: github.repository == 'feast-dev/feast'
     runs-on: ubuntu-latest
-    needs: [ get-version ]
     strategy:
       matrix:
         component: [ feature-server, feature-server-java, feature-transformation-server, feast-helm-operator, feast-operator ]
     env:
       MAVEN_CACHE: gs://feast-templocation-kf-feast/.m2.2020-08-19.tar
       REGISTRY: feastdev
     steps:
+      - id: get-version
+        uses: ./.github/workflows/get_semantic_release_version.yml
+        with:
+          custom_version: ${{ github.event.inputs.custom_version }}
+          token: ${{ github.event.inputs.token }}
       - uses: actions/checkout@v4
       - name: Set up QEMU
         uses: docker/setup-qemu-action@v1
@@ -63,17 +61,14 @@ jobs:
         run: gcloud info
       - run: gcloud auth configure-docker --quiet
       - name: Build image
+        env:
+          VERSION_WITHOUT_PREFIX: ${{ steps.get-version.outputs.version_without_prefix }}
         run: |
           make build-${{ matrix.component }}-docker REGISTRY=${REGISTRY} VERSION=${VERSION_WITHOUT_PREFIX}
-        env:
-          RELEASE_VERSION: ${{ needs.get-version.outputs.release_version }}
-          VERSION_WITHOUT_PREFIX: ${{ needs.get-version.outputs.version_without_prefix }}
-          HIGHEST_SEMVER_TAG: ${{ needs.get-version.outputs.highest_semver_tag }}
       - name: Push versioned images
         env:
-          RELEASE_VERSION: ${{ needs.get-version.outputs.release_version }}
-          VERSION_WITHOUT_PREFIX: ${{ needs.get-version.outputs.version_without_prefix }}
-          HIGHEST_SEMVER_TAG: ${{ needs.get-version.outputs.highest_semver_tag }}
+          VERSION_WITHOUT_PREFIX: ${{ steps.get-version.outputs.version_without_prefix }}
+          HIGHEST_SEMVER_TAG: ${{ steps.get-version.outputs.highest_semver_tag }}
         run: |
           make push-${{ matrix.component }}-docker REGISTRY=${REGISTRY} VERSION=${VERSION_WITHOUT_PREFIX}