Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent unnecessary caret movement issue: #824 #825

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion src/components/SearchInput.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,20 @@ function SearchInput({ placeholder, value, onChange, ...props }) {
return () => window.removeEventListener('keydown', handleKeyDown)
}, [])

function handleChange(event) {
const currentCaret = inputElement.current;
const caretPosition = currentCaret.selectionStart; // will Save caret position

if (onChange) {
onChange(event.target.value); // Update the value
}

// Restore caret position after value update
setTimeout(() => {
currentCaret.setSelectionRange(caretPosition, caretPosition);
}, 0);
}

return (
<div css={{ position: 'relative' }} {...props}>
<div
Expand All @@ -39,7 +53,7 @@ function SearchInput({ placeholder, value, onChange, ...props }) {
aria-label="Search"
placeholder={placeholder}
value={value}
onChange={onChange}
onChange={handleChange}
sx={{
width: '100%',
margin: 0,
Expand Down
2 changes: 1 addition & 1 deletion src/pages/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ function IndexPage({ location }) {
Object.keys(icons).length
} icons (Press "/" to focus)`}
value={query || ''}
onChange={event => setQuery(event.target.value)}
onChange={setQuery}
/>
</div>
<div sx={{ paddingX: 4 }}>
Expand Down