A close macro implementation for AccountInfo #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
febo
reviewed
Nov 17, 2024
febo
reviewed
Nov 17, 2024
febo
reviewed
Nov 20, 2024
febo
reviewed
Nov 20, 2024
febo
reviewed
Nov 20, 2024
febo
reviewed
Nov 20, 2024
febo
reviewed
Nov 20, 2024
febo
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRd this macro implementation invented by @deanmlittle (known as
based_close) in the Pinocchio AccountInfo implementation to use it more easily.I added 2 different function + docs:
.close(): the implementation with pointer of the underlying idea.optimized_close(): the implementation with assembly of the underlying idea (marked the implementation as unsafe function since it usesasm_experimental_archSome data about the CU usage:
.close(): takes 60 CUs.optimized_close(): takes 7 CUsEdit: now close has 7CUs as well (thanks to @febo's comment) and
optimized_close()is now calledassembly_close()