Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Realloc Macro #45

Merged
merged 6 commits into from
Nov 20, 2024
Merged

Fixed Realloc Macro #45

merged 6 commits into from
Nov 20, 2024

Conversation

L0STE
Copy link
Contributor

@L0STE L0STE commented Nov 20, 2024

Realloc was broken when trying to use it in a program with the following error:

= note: Undefined symbols for architecture arm64:
"_sol_memset_", referenced from:
    pinocchio::account_info::AccountInfo::realloc::h7b767197c3b52406 in libpinocchio-b1a74aa98b057767.rlib(pinocchio-b1a74aa98b057767.8lu0acfwt9wrlqb8ft0k7wz4l.rcgu.o)
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

By specifying that it needs to target Solana as os this problem is not there anymore

febo
febo reviewed Nov 20, 2024
View reviewed changes
Copy link
Owner

@febo febo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just some nits before we can merge it.

febo
febo approved these changes Nov 20, 2024
View reviewed changes
Copy link
Owner

@febo febo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@febo febo merged commit 38d9bc6 into febo:main Nov 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@febo febo febo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@L0STE @febo