Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6445 MUR citation filters #6588

Merged
merged 11 commits into from
Jan 16, 2025
Merged

Conversation

rfultz
Copy link
Contributor

@rfultz rfultz commented Dec 10, 2024

Summary

Adding the citations filters for MURs searches
ALSO fixed a related oversight for AOs search

Required reviewers

  • front-end
  • UX and/or SMEs

Impacted areas of the application

  • MURs templates
  • views.py
  • typeahead filters can now handle citations
  • tweaks to other Legal pagination button values (instead of one huge string)
  • legal search results template for filter tag updates
  • AOs templates

Screenshots

image

Updated filter order:

1 2 3 4
image image image image

The document date tooltip
image

Related PRs

None

How to test

  • pull the branch
  • npm run build
  • MURs
    • Order of filters and new accordion elements
    • Try to break the filters, especially those for citations
    • Try to break the tags (the 'filtered by' bits above the table)
    • Review complicated filters' pagination buttons (prev, numbers, and next)
  • Admin fines
    • Make sure the tags and pagination buttons haven't changed (i.e. they're still working)
  • Advisory Opinions
    • Tags and pagination
    • Statutory citation filter should now work
    • "Show cases citing [any|all] of them" should now work
  • Alternative Dispute Resolutions
    • Tags and pagination
  • Regulations
    • Tags and pagination
  • Statutes
    • Tags and pagination

@rfultz rfultz added this to the 27.1 milestone Dec 10, 2024
@rfultz rfultz self-assigned this Dec 10, 2024
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 79.64%. Comparing base (8f7972f) to head (3b55354).
Report is 28 commits behind head on develop.

Files with missing lines Patch % Lines
fec/legal/views.py 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6588      +/-   ##
===========================================
- Coverage    79.72%   79.64%   -0.08%     
===========================================
  Files          235      235              
  Lines         5159     5164       +5     
===========================================
  Hits          4113     4113              
- Misses        1046     1051       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rfultz rfultz marked this pull request as ready for review December 11, 2024 10:54
@rfultz rfultz changed the title Feature/6445 mur citation filters 6445 MUR citation filters Dec 11, 2024
@rfultz rfultz mentioned this pull request Dec 11, 2024
6 tasks
@rfultz rfultz modified the milestones: 27.1, 27.2 Dec 23, 2024
@rfultz rfultz modified the milestones: 27.2, 27.3 Jan 7, 2025
@patphongs patphongs changed the base branch from develop to release/public-20250114 January 10, 2025 16:59
@patphongs patphongs changed the base branch from release/public-20250114 to develop January 13, 2025 18:04
Copy link
Member

@patphongs patphongs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great now, thanks @rfultz

@patphongs patphongs merged commit aa852a8 into develop Jan 16, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Build out MUR citation filters
2 participants