Reverts the Support to Upsert/Insert Ignore on PDB #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ity (feedzai#407)" This reverts commit 94ba1a5.
This reverts commit 46f29b2.
This reverts commit 963cd30.
This reverts commit d4f7c4e.
This reverts commit d626297.
This reverts commit 1d32f7f.
This reverts commit 36a434c.
This reverts commit 1658965.
This reverts commit d2f153b.
This reverts commit 2f0d1ff
This reverts commit 348a22d
This reverts commit e100a51
|
LGTM! Just one quick note: please improve the PR summary with the rational/business need to revert these changes. |
good call! updated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, it was added a support for the upsert of entries in the
pdblibrary.The feature added supported for entities to, when applicable, be able to be upserted or depending on the engine implementation, an insert ignore or even merge. The feature also enabled the upsert feature for batch processing, i.e. entries could now use the new upsert API. However, after its usage it was possible to conclude it decreased performance when client application used this new API. Giving the degrading performance and also the log messages some of the entities generated for not having the upsert statement available, it was decided to remove this feature entirely from the
pdbcode-base.This series of commit reverts the feature to upsert entries on
pdb. The reverted commits reverted are as follows.