Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added marathi translation #29

Merged
merged 3 commits into from
Oct 29, 2018
Merged

Added marathi translation #29

merged 3 commits into from
Oct 29, 2018

Conversation

VivekMolkar
Copy link
Contributor

Added Marathi translation in response to issue #16

src/index.js Outdated
@@ -18,6 +18,7 @@ import tr from 'react-intl/locale-data/tr'; // Turkish
import uk from 'react-intl/locale-data/uk'; // Ukrainian
import ru from 'react-intl/locale-data/ru'; // Russian
import it from 'react-intl/locale-data/it'; // Italian
import mr from 'react-intl/locale-data/mr'; // Italian
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Italian?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be Marathi, Updating it, Sorry for that.

@@ -18,6 +18,7 @@ import tr from 'react-intl/locale-data/tr'; // Turkish
import uk from 'react-intl/locale-data/uk'; // Ukrainian
import ru from 'react-intl/locale-data/ru'; // Russian
import it from 'react-intl/locale-data/it'; // Italian
import mr from 'react-intl/locale-data/mr'; // Italian

import { flattenMessages } from './js/utils'; // flatten messages util function in order to use nested js object for translated texts
import messages from './messages';
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also forgot ti import the marathi locale for moment.js

Copy link
Contributor Author

@VivekMolkar VivekMolkar Oct 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for my ignorance, I'll update the code

@felipemarinho97 felipemarinho97 merged commit 212cc25 into felipemarinho97:master Oct 29, 2018
@VivekMolkar VivekMolkar deleted the mr-translation branch October 30, 2018 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants