mutable_fws_multimap::insert -> return iterator instead of ref

felixguendling · Jun 1, 2023 · b1db434 · b1db434
1 parent 8c090ea
commit b1db434
Showing 1 changed file with 10 additions and 6 deletions.
diff --git a/include/cista/containers/mutable_fws_multimap.h b/include/cista/containers/mutable_fws_multimap.h
@@ -143,13 +143,17 @@ struct dynamic_fws_multimap_base {
     }
 
     template <bool IsConst = Const, typename = std::enable_if_t<!IsConst>>
-    void insert(iterator it, value_type const& val) {
-      prepare_insert(it) = val;
+    iterator insert(iterator it, value_type const& val) {
+      auto insert_it = prepare_insert(it);
+      *insert_it = val;
+      return insert_it;
     }
 
     template <bool IsConst = Const, typename = std::enable_if_t<!IsConst>>
-    void insert(iterator it, value_type&& val) {
-      prepare_insert(it) = std::move(val);
+    iterator insert(iterator it, value_type&& val) {
+      auto insert_it = prepare_insert(it);
+      *insert_it = std::move(val);
+      return insert_it;
     }
 
     template <bool IsConst = Const, typename = std::enable_if_t<!IsConst>>
@@ -242,15 +246,15 @@ struct dynamic_fws_multimap_base {
     }
 
     template <bool IsConst = Const, typename = std::enable_if_t<!IsConst>>
-    value_type& prepare_insert(bucket::iterator it) {
+    iterator prepare_insert(bucket::iterator it) {
       auto const pos = std::distance(begin(), it);
       auto& index = get_index();
       reserve(index.size_ + 1U);
       it = std::next(begin(), pos);
       std::move_backward(it, end(), std::next(end()));
       ++index.size_;
       ++mutable_mm().element_count_;
-      return *it;
+      return it;
     }
 
     dynamic_fws_multimap_base& mutable_mm() noexcept {