Revert #592 #703
Closed
Revert #592 #703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thank you for this PR. |
I'll try and setup a condesandbox for you later today. |
|
@felixmosh actually.. this PR isn't the solution. Apparently #592 only applies to Express and #639 adds Fastify support. But both lack a leading forward slash on the prefix to load the static folder correctly. Should I update this PR or create a new one? |
|
Closed in favor of #704 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe something changed recently, but PR #592 is actually causing issue #607.
Reverting that change will make PR #639 unnecessary.
The problem mentioned in PR #591 doesn't happen anymore.