Rollback to old version comparision + use new as fallback (really rea…

…lly lame native, seriously....)
femtopixel · May 31, 2019 · f5c7ee6 · f5c7ee6
1 parent d17770c
commit f5c7ee6
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/Makefile b/Makefile
@@ -1,4 +1,4 @@
-VERSION ?= 0.4.2
+VERSION ?= 0.4.3
 CACHE ?= --no-cache=1
 FULLVERSION ?= ${VERSION}
 archs ?= arm32v7 amd64 i386 arm64v8 arm32v6

diff --git a/github_release_notifier/__init__.py b/github_release_notifier/__init__.py
@@ -3,4 +3,4 @@
 """
 
 __all__ = ['parser', 'webhook', 'notifier']
-__version__ = '0.4.2'
+__version__ = '0.4.3'
diff --git a/github_release_notifier/notifier.py b/github_release_notifier/notifier.py
@@ -37,9 +37,9 @@ def run(file: str = __DEFAULT_FILE__) -> dict:
         try:
             for entry in parse(package):
                 try:
-                    condition = LooseVersion(str(entry['version'])) > LooseVersion(str(get_version(package)))
-                except TypeError as e:
                     condition = version_compare(str(entry['version']), str(get_version(package))) > 0
+                except ValueError as e:
+                    condition = LooseVersion(str(entry['version'])) > LooseVersion(str(get_version(package)))
                 if condition:
                     database = _get_database(file)
                     database[package] = entry['version']