Skip to content

Commit

Permalink
Merge pull request #81 from fenix-hub/dev
Browse files Browse the repository at this point in the history
Update v1.3.6
  • Loading branch information
fenix-hub authored Dec 21, 2020
2 parents b37c854 + 709d49d commit 1da8fac
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 5 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,15 @@ This plugin is now supported in [Godot Extended Library Discord](https://discord
A complete GitHub integration for your Godot Editor! Manage your project without even opening your browser.

Author: *"Nicolo (fenix) Santilio"*
Version: *1.3.5*
Version: *1.3.6*
Wiki: *[supported](https://github.com/fenix-hub/godot-engine.github-integration/wiki)*
Godot Version: *3.2.3stable*

<img align="center" src="addons/github-integration/screenshots/banner.png">

## What is this?
*GitHub Integration* is a addon for Godot Engine that I've created mainly for a personal purpose.
Pushing and Pulling personal repositories while I'm working on Godot (especially if I'm under a GameJam) could take some time and force me to save the project, open the brwoser/git bash/git gui, and do all the stuff.
Pushing and Pulling repositories while I'm working on Godot (especially if I'm under a GameJam) could take some time and force me to save the project, open the brwoser/git bash/git gui, and do all the stuff.
With this little addon which works directly in the editor, managing all your repositories will be very easy.

## What can it do?
Expand Down
2 changes: 1 addition & 1 deletion addons/github-integration/plugin.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@
name="GitHub integration"
description="Plugin to integrate GitHub requests directly via Godot Engine Editor"
author="Nicolo (fenix) Santilio"
version="1.3.4"
version="1.3.6"
script="scripts/github-integration.gd"
2 changes: 1 addition & 1 deletion addons/github-integration/scripts/Commit.gd
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ func connect_signals():
func request_completed(result, response_code, headers, body ):
get_parent().print_debug_message("REQUEST TO API : Request exited with code %s" % response_code)
if response_code == 422:
get_parent().print_debug_message(JSON.parse(body.get_string_from_utf8()).result)
get_parent().print_debug_message(str(JSON.parse(body.get_string_from_utf8()).result))
if result == 0:
match requesting:
REQUESTS.UPLOAD:
Expand Down
7 changes: 7 additions & 0 deletions addons/github-integration/scripts/ContributorClass.gd
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ onready var login_lbl : Label = $Login
onready var name_lbl : Label = $Name
onready var client : HTTPRequest = $HTTPRequest

var is_downloading : bool = false

var _avatar : String
var _name : String
var _login : String
Expand All @@ -32,6 +34,10 @@ func set_contributor_name(n : String) -> void:
func set_contributor_avatar(a : String) -> void:
_avatar = a
client.request(_avatar)
is_downloading = true

func _process(delta):
if is_downloading: print(client.get_downloaded_bytes()/client.get_body_size()*100, " %")

func _on_request_completed(result: int, response_code: int, headers: PoolStringArray, avatar: PoolByteArray) -> void:
if result == 0:
Expand All @@ -46,3 +52,4 @@ func _on_request_completed(result: int, response_code: int, headers: PoolStringA
var texture : ImageTexture = ImageTexture.new()
texture.create_from_image(image)
avatar_texture.set_texture(texture)
is_downloading = false
2 changes: 1 addition & 1 deletion addons/github-integration/scripts/PluginSettings.gd
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ func _check_plugin_path():
var dir = Directory.new()
if not dir.dir_exists(plugin_path):
dir.make_dir(plugin_path)
if PluginSettings.debug:
if debug:
printerr("[GitHub Integration] >> ","made custom directory in user folder, it is placed at ", plugin_path)

func _ready():
Expand Down

0 comments on commit 1da8fac

Please sign in to comment.