Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(install): update install script to support more OS types #1244

Merged

Conversation

kate-goldenring
Copy link
Contributor

Updates the install script to:

  1. detect if the OS is using musl and should use the bin with statically linked deps
  2. the $OSTYPE is just "linux" to support OpenSUSE OS (issue described in discord here
  3. Removes unnecessary wrapping of spin directory in array which makes the syntax unsupported by sh

@karthik2804
Copy link
Contributor

We may also want to optionally handle the installation of plugins. The plugins installed on linux-musl will probably be broken as we do not distinguish between libc.

@kate-goldenring
Copy link
Contributor Author

We may also want to optionally handle the installation of plugins. The plugins installed on linux-musl will probably be broken as we do not distinguish between libc.

@karthik2804 to clarify, that means folks using a distro that uses musl cannot write JS spin apps because that requires a plugin right? Should we track this as an issue somewhere -- building plugins with statically linked deps?

@karthik2804
Copy link
Contributor

@kate-goldenring, Yeah - any of the plugins will not work. The JS stuff will be replaced soon once we move over but things like cloud, kube and the trigger-plugins will not. I am not sure building all plugins as statically linked binaries is the best approach here. We may want spin to gain knowledge and fetch appropriate plugins?

@flynnduism
Copy link
Member

@kate-goldenring @karthik2804

As we prepare to migrate spin docs to a CNCF org, can we review and resolve this PR?

@kate-goldenring
Copy link
Contributor Author

@karthik2804 how about i update this to not install plugins for a musl os?

@karthik2804
Copy link
Contributor

@kate-goldenring That sounds reasonable as users will have to build their own static release.

@kate-goldenring kate-goldenring force-pushed the install-script-support-more-os branch from 9364a7a to b9c20bf Compare February 13, 2025 18:32
@kate-goldenring
Copy link
Contributor Author

@karthik2804 realizing i already made that change. Just rebased -- this is ready for review

Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com>
Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com>
@kate-goldenring kate-goldenring force-pushed the install-script-support-more-os branch from b9c20bf to 07bbe40 Compare February 13, 2025 23:33
@kate-goldenring kate-goldenring merged commit 78a978e into fermyon:main Feb 14, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants