-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(install): update install script to support more OS types #1244
fix(install): update install script to support more OS types #1244
Conversation
We may also want to optionally handle the installation of plugins. The plugins installed on |
@karthik2804 to clarify, that means folks using a distro that uses musl cannot write JS spin apps because that requires a plugin right? Should we track this as an issue somewhere -- building plugins with statically linked deps? |
@kate-goldenring, Yeah - any of the plugins will not work. The JS stuff will be replaced soon once we move over but things like |
As we prepare to migrate spin docs to a CNCF org, can we review and resolve this PR? |
@karthik2804 how about i update this to not install plugins for a musl os? |
@kate-goldenring That sounds reasonable as users will have to build their own static release. |
9364a7a
to
b9c20bf
Compare
@karthik2804 realizing i already made that change. Just rebased -- this is ready for review |
Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com>
Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com>
b9c20bf
to
07bbe40
Compare
Updates the install script to:
sh