Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(oci): update oci-distribution crate to get jwt fix #2983

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

vdice
Copy link
Member

@vdice vdice commented Jan 16, 2025

Updates the rev of the fermyon/oci-distribution crate to get a fix in the underlying jwt crate to properly handle aud fields on a JWT claim. Ref fermyon/oci-distribution#4 for further context.

JWTs with aud fields consisting of an array of strings would previously fail to parse, which caused the oci-distribution crate to not add the token to the cache, failing any OCI api requests.

@vdice
Copy link
Member Author

vdice commented Jan 16, 2025

Integration test appears failure for the redis-go template is unrelated; I believe it is due to be fixed in #2981:

PATH="target/debug:target/release:/home/runner/.cargo/bin:/home/runner/work/spin/spin:/opt/hostedtoolcache/node/20.18.1/x64/bin:/opt/hostedtoolcache/binaryen/116/x86_64/binaryen-version_116/bin:/opt/hostedtoolcache/tinygo/0.35.0/amd64/tinygo/bin:/home/runner/go/bin:/opt/hostedtoolcache/go/1.22.10/x64/bin:/opt/hostedtoolcache/zig/master/x64:/snap/bin:/home/runner/.local/bin:/opt/pipx_bin:/home/runner/.cargo/bin:/home/runner/.config/composer/vendor/bin:/usr/local/.ghcup/bin:/home/runner/.dotnet/tools:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin:/home/runner/work/spin/spin/target/release" "/home/runner/work/spin/spin/target/release/spin" "build"' failed with status code Some(1)
test integration_tests::redis_go_template_smoke_test ... FAILED
stdout:
Building component test with `tinygo build -target=wasi -gc=leaking -no-debug -o main.wasm main.go`

stderr:
wasm-ld: error: /tmp/tinygo2244649061/main.o: undefined symbol: main.main
Error: Build command for component test failed with status Exited(1)

@lann lann merged commit 70f2d54 into fermyon:main Jan 16, 2025
16 of 17 checks passed
@vdice vdice deleted the fix/oci-jwt-crate-patch branch January 16, 2025 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants