fix(cli): render images in local preview #5889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Edsun457
force-pushed
the
edwardsun/render-local-image
branch
2 times, most recently
from
1e91289 to
f53163f
Compare
dsinghvi
changed the title
dsinghvi
reviewed
Feb 4, 2025
dsinghvi
reviewed
Feb 4, 2025
dsinghvi
reviewed
Feb 4, 2025
| const path = "/" + file.url.replace("/_local/", ""); | ||
| return [AbsoluteFilePath.of(path), id]; | ||
| }) | ||
| ); |
There was a problem hiding this comment.
what is happening in this transformation here?
|
Before you merge, you'll want to add a changelog to https://github.com/fern-api/fern/blob/main/packages/cli/cli/versions.yml -- that way a new version will get published to npm |
Edsun457
force-pushed
the
edwardsun/render-local-image
branch
from
7e6a617 to
76277ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix ticket #5756
Cause of the issue
In local environment when re-rendering markdown files, the image rendered to browser as file relative path. The browser can not parse the image unless it's the image ID matched in FileV2
For example:
<img src="./table-of-contents.png" alt="Table of contents feature" />What this PR fixed
<img src="file:86a5f557-626e-418e-9e7a-e9f1cdc723f2" alt="Edit this page feature" />Changes Made
Add logic to populate image file id so would render the right image to the browser for local env
Testing